Implement a custom GyrDiskService for ActiveStorage to workaround CircleCI issues #1885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tgrathwell
force-pushed
the
custom-activestorage-service-to-make-circleci-work-for-now-#180524323
branch
from
0d8f70e
to
3519117
Compare
tgrathwell
force-pushed
the
custom-activestorage-service-to-make-circleci-work-for-now-#180524323
branch
from
3519117
to
cecf7cf
Compare
caitbot
approved these changes
Dec 3, 2021
| # We should be able to remove this if CircleCI starts using a different linux kernel version (currently 5.4.0-1060-aws) | ||
|
|
||
| File.write(make_path_for(key), io.read) | ||
| io.rewind |
There was a problem hiding this comment.
why do rewind? is this because it is the state that IO.copy_stream leaves io in?
There was a problem hiding this comment.
I have some paranoia about IO files getting angry if someone tries to read them twice, though I didn't actually see that problem in real life yet for this code
everything I've tried so far has made some tests pass but others fail; I've done another revision where it only tries to File.write if the io object is an actual file, let's see if that fares any better
…cleCI issues As seen in this issue, certain versions of Docker and certain versions of the Linux kernel manifest a problem where creating tempfiles wiht `IO.copy_stream` doesn't work: docker/for-linux#1015 CircleCI seems to have upgraded their linux kernels and now we're seeing this problem. A temporary workaround is to change the ActiveStorage code to not use IO.copy_stream by making a custom service (since the Disk service is only for test anyway so we can do whatever we want)
tgrathwell
force-pushed
the
custom-activestorage-service-to-make-circleci-work-for-now-#180524323
branch
from
cecf7cf
to
506af86
Compare
tgrathwell
deleted the
custom-activestorage-service-to-make-circleci-work-for-now-#180524323
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As seen in this issue, certain versions of Docker and certain versions of the Linux
kernel manifest a problem where creating tempfiles wiht
IO.copy_streamdoesn't work:docker/for-linux#1015
CircleCI seems to have upgraded their linux kernels and now we're seeing this problem.
A temporary workaround is to change the ActiveStorage code to not use IO.copy_stream
by making a custom service (since the Disk service is only for test anyway so we can
do whatever we want)